Not a bug Server error if Elasticsearch is not running

AndyB

Well-known member

• Dec 3, 2021

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #1

Affected version

Enhanced search v2.2.2

If Elasticsearch is not running and you try to do a search the following server error is displayed:



If Elasticsearch is not running, it would be better to return this error phrase:

return $this->error(\XF::phrase('xfes_elasticsearch_server_could_not_be_reached'));

 

Last edited: Dec 3, 2021

DreamNetworks

Active member

• Dec 23, 2021

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #2

Nice suggestion ! If we want to know the details we will always check xf logs

 

Rasmus Vind

Well-known member

• Jan 20, 2022

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #3

I believe XF only displays exceptions if DEBUG is enabled in your config.php. Otherwise it gives a less technical error.

Also. Normal users have no idea what ElasticSearch is and don’t care. All they need to know is that the page is temporarily unavailable.

 

AndyB

Well-known member

• Jan 20, 2022

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #4

Ralle said:

I believe XF only displays exceptions if DEBUG is enabled in your config.php

Click to expand...

In my testing, same error is produced weather debug mode is enabled or not.

 

Rasmus Vind

Well-known member

• Jan 21, 2022

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #5

My users don’t see these errors when they occur. I wonder if it is different if you are not admin or not logged in.

 

webbouk

Well-known member

• Jan 21, 2022

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #6

I believe that error would only show in the ACP therefore only visible to admins with the correct permissions

 

P

Paul B

XenForo moderator

Staff member

• Jan 21, 2022

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #7

The error shows on the front end to any logged in member but only if debug mode is enabled.

 

PaulB

Well-known member

• Feb 1, 2022

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #8

Brogan said:

The error shows on the front end to any logged in member but only if debug mode is enabled.

Click to expand...

I was observing different behavior: the trace was showing even with debug mode disabled.

Looking at \XF\ControllerPlugin\Error::actionException, it seems the logic is to display the error if the site is in debug mode or the current visitor is an admin. Otherwise, a generic error with no trace will be displayed.

 

AndyB

Well-known member

• Feb 1, 2022

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #9

I just checked and indeed if I'm logged in a normal registered user and Elasticsearch is not running, I get a proper message like this:

 

Jeremy P

XenForo developer

Staff member

• Mar 21, 2022

• %22 data-success="Embed code HTML copied to clipboard." class="">
• #10

I don't think we'll be making any changes here. There are a number of places which make calls that will throw if a connection to Elasticsearch cannot be established, and indeed the exception is only displayed to administrators or while in debug mode. This shouldn't occur under normal circumstances anyway.